Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for refresh tokens to be used via access_type "offline" in Issue/#619 #634

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

aaronware
Copy link
Contributor

I might need some support here as I wasn't able to figure out the most efficient way to test my changes based on how this all works within a worker? Any shove in the right direction would be greatly appreciated for proper testing.

@aaronware
Copy link
Contributor Author

I also don't really understand why it had my other pull requests in the commit logs... No changes for those files are actually in this pull request

@aaronware
Copy link
Contributor Author

Closes #619

@yusukebe
Copy link
Member

Hi @aaronware

Thanks for the PR. I think it would be fine if you tested it with the npm link though we should add more test codes.

@monoald Do you have any thoughts on this?

@aaronware
Copy link
Contributor Author

Thanks @yusukebe , I got pulled away from this onto some items but I should have some time over the next week to confirm it's all working properly within the worker. @yusukebe I'll keep an eye out for any recommendations/changes you or @monoald have and adjust the PR as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants