Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Emitter middleware #615

Merged
merged 6 commits into from
Jul 7, 2024
Merged

Event Emitter middleware #615

merged 6 commits into from
Jul 7, 2024

Conversation

DavidHavl
Copy link
Contributor

@DavidHavl DavidHavl commented Jul 3, 2024

I have created event-emitter middleware for Hono and as discussed here I am opening a pull request in this repo instead of the main @hono/hono one as it is a better fit for it.
Thank you @yusukebe

This middleware enables event-driven logic flow in hono applications (essential in larger projects or projects with a lot of interactions between features).

Inspired by event emitter concept in other frameworks such
as Adonis.js, Nest.js, Hapi.js, Laravel, Sails.js, Meteor and others.

For usage examples, see the README file of the package.

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: a4400cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/event-emitter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.github/workflows/ci-event-emitter.yml Outdated Show resolved Hide resolved
packages/event-emitter/CHANGELOG.md Outdated Show resolved Hide resolved
packages/event-emitter/package.json Outdated Show resolved Hide resolved
@yusukebe
Copy link
Member

yusukebe commented Jul 6, 2024

Hi @DavidHavl

Thank you for the PR. Almost all look good! I've left some comments.

@DavidHavl
Copy link
Contributor Author

Thank you @yusukebe,
I made the requested changes.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jul 7, 2024

@DavidHavl

Thanks! I'll merge this now. I'm glad you contributed to Hono!

@yusukebe yusukebe merged commit 53b4f33 into honojs:main Jul 7, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants