Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clerk-auth: Migrate to Clerk Core v2 #465

Merged
merged 19 commits into from
Apr 25, 2024
Merged

Conversation

MonsterDeveloper
Copy link
Contributor

Yesterday Clerk Core v2 was released.

This PR updates the clerk-auth middleware to use the new version of Clerk Backend API.

I updated the middleware according to the official Clerk's migration guide, as well as the tests (based on the Clerk's Fastify middleware.

Copy link

changeset-bot bot commented Apr 20, 2024

🦋 Changeset detected

Latest commit: 8310fe1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/clerk-auth Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@octoper octoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MonsterDeveloper, thank you for the amazing job with this PR!

I've left some changes that need to be made before merging it

packages/clerk-auth/package.json Outdated Show resolved Hide resolved
packages/clerk-auth/package.json Outdated Show resolved Hide resolved
packages/clerk-auth/src/index.ts Show resolved Hide resolved
packages/clerk-auth/src/index.ts Outdated Show resolved Hide resolved
packages/clerk-auth/jest.config.cjs Show resolved Hide resolved
packages/clerk-auth/src/index.ts Outdated Show resolved Hide resolved
@yusukebe
Copy link
Member

@MonsterDeveloper @octoper Thanks both! I'll merge it when it is finished.

@MonsterDeveloper
Copy link
Contributor Author

@octoper hey, thanks for your comments! Made some changes, and left some questions in the conversations. Would appreciate your review:)

@yusukebe yusukebe mentioned this pull request Apr 23, 2024
@MonsterDeveloper
Copy link
Contributor Author

@octoper seems like everything is resolved now. Are we ready to merge?

packages/clerk-auth/src/index.ts Outdated Show resolved Hide resolved
packages/clerk-auth/src/index.ts Show resolved Hide resolved
@dimkl
Copy link

dimkl commented Apr 25, 2024

Nice work @MonsterDeveloper!!

@octoper
Copy link
Contributor

octoper commented Apr 25, 2024

@yusukebe This is ready to be merged when you find the time (sorry for the ping)!

@yusukebe
Copy link
Member

@MonsterDeveloper @octoper

Thanks! Great work! Shipping it now.

@yusukebe yusukebe merged commit 1823a28 into honojs:main Apr 25, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants