-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clerk-auth: Migrate to Clerk Core v2 #465
Conversation
🦋 Changeset detectedLatest commit: 8310fe1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MonsterDeveloper, thank you for the amazing job with this PR!
I've left some changes that need to be made before merging it
@MonsterDeveloper @octoper Thanks both! I'll merge it when it is finished. |
@octoper hey, thanks for your comments! Made some changes, and left some questions in the conversations. Would appreciate your review:) |
@octoper seems like everything is resolved now. Are we ready to merge? |
Nice work @MonsterDeveloper!! |
@yusukebe This is ready to be merged when you find the time (sorry for the ping)! |
Thanks! Great work! Shipping it now. |
Yesterday Clerk Core v2 was released.
This PR updates the
clerk-auth
middleware to use the new version of Clerk Backend API.I updated the middleware according to the official Clerk's migration guide, as well as the tests (based on the Clerk's Fastify middleware.