Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: file upload middleware #145

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krsbx
Copy link

@krsbx krsbx commented Sep 1, 2023

Just a file upload middleware so the file can be saved to disk or passed to firebase firestorage or aws s3

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

⚠️ No Changeset found

Latest commit: 7ef0fa1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@krsbx krsbx marked this pull request as ready for review September 1, 2023 01:04
@yusukebe
Copy link
Member

yusukebe commented Sep 1, 2023

I cannot merge it. Sorry.

@krsbx krsbx closed this Sep 1, 2023
@krsbx
Copy link
Author

krsbx commented Sep 26, 2023

@yusukebe sorry to bring this thing up again but is it cool if we just add this one the node-adapter instead? if yes, then i'll make a PR there

@yusukebe
Copy link
Member

Hi @krsbx

You do not need to create a PR immediately, but I would like to think more about file uploads. So, I will not merge it, but I will reopen this PR so that I do not forget it. Thanks.

@sourabpramanik
Copy link

Where are we with this? This new integration is in the roadmap or should we wait?

Willing to take this forward if that's okay

@yusukebe
Copy link
Member

yusukebe commented Jun 8, 2024

Hi @sourabpramanik

We don't plan to add a file upload feature. But you can use this one: https://github.com/sor4chi/hono-storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants