Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(perf-measures): support KB #3696

Merged
merged 4 commits into from
Nov 23, 2024
Merged

ci(perf-measures): support KB #3696

merged 4 commits into from
Nov 23, 2024

Conversation

EdamAme-x
Copy link
Contributor

We can check kb

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (44a50bd) to head (6d5f27f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3696   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         159      159           
  Lines       10145    10145           
  Branches     2879     2864   -15     
=======================================
  Hits         9303     9303           
  Misses        840      840           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@EdamAme-x
Copy link
Contributor Author

@EdamAme-x
Copy link
Contributor Author

Interesting 👀

@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Nov 21, 2024

It seems to work well.
thanks @k2tzumi

@yusukebe
Copy link
Member

Hi @EdamAme-x

Good PR! One thing I noticed.

When displaying Bundle Size, I think it would be easier to compare "K" with "B":

CleanShot 2024-11-22 at 09 21 29@2x

In the above, the "B" and "KB" digits appear to be aligned. ls -lh command also uses the method I suggest, so it's okay.

CleanShot 2024-11-22 at 09 25 58@2x

@EdamAme-x
Copy link
Contributor Author

thanks for suggestions

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@EdamAme-x

Thank! Merging.

@yusukebe yusukebe merged commit 8717946 into honojs:main Nov 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants