-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(perf-measures): support KB
#3696
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3696 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 159 159
Lines 10145 10145
Branches 2879 2864 -15
=======================================
Hits 9303 9303
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Interesting 👀 |
Co-authored-by: Katsumi Kato <[email protected]>
It seems to work well. |
Hi @EdamAme-x Good PR! One thing I noticed. When displaying Bundle Size, I think it would be easier to compare "K" with "B": In the above, the "B" and "KB" digits appear to be aligned. |
thanks for suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank! Merging. |
We can check
kb