feat(helper/factory): Calculate Context<Env> Type in createHandlers #3670
+203
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushichan044
changed the title
sushichan044
force-pushed
the
create-handler-type
branch
from
452f209 to
68991e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3670 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 159 159
Lines 10145 10145
Branches 2851 2857 +6
=======================================
Hits 9303 9303
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Awesome! Thank you for your first contribution. Merging now. |
|
I raised #3467 and I'm so happy to hear it is fixed. It is super helpful. I will try it soon. Thank you @sushichan044 and @yusukebe ! |
|
I brought this issue up in the discord. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3467
This PR fixes a problem in createHandlers where the expected type information was not passed to subsequent handlers
when middlewares changed the Context type.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code