Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use @clack/core instead of @inquirer/* #68

Closed
wants to merge 5 commits into from
Closed

feat: Use @clack/core instead of @inquirer/* #68

wants to merge 5 commits into from

Conversation

goisaki
Copy link
Contributor

@goisaki goisaki commented Aug 24, 2024

This PR changes @inquirer/* and nanospinner to @clack/core and custom implementation.
It would improve installation size and speed.

Related: #66

@yusukebe
Copy link
Member

yusukebe commented Sep 1, 2024

@goisaki

If it's ready, please ping me!

@goisaki goisaki marked this pull request as ready for review September 8, 2024 06:04
@goisaki
Copy link
Contributor Author

goisaki commented Sep 8, 2024

It is ready now!
I will now add a test for itself and mock for the other tests.
Make sure it looks and works.

@yusukebe @MathurAditya724 @ryuapp and others, if you have time please review!

@goisaki
Copy link
Contributor Author

goisaki commented Sep 8, 2024

Oops, that didn't make sense.
@yusukebe, should we close this or just replace it?

Screenshot 2024-09-08 at 15 34 07

@yusukebe
Copy link
Member

yusukebe commented Sep 8, 2024

@goisaki OOOps. Just a moment.

@yusukebe
Copy link
Member

@goisaki

Hmmmm. Unfortunately, I think it's better to keep the current implementation.

@goisaki goisaki closed this Sep 10, 2024
@yusukebe
Copy link
Member

@goisaki

Thank you for taking your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants