Skip to content

Commit

Permalink
Updates as per reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
gitvinit committed Apr 13, 2023
1 parent 85f7c58 commit dee4f48
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion hack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ pushing directly to a local registry and configuring kind to use this reg, so do
isnt required.
- Or a `tilt` recipe which hot reloads all kpng on code changes.


## Code formating
**We should run `hack/verify-gofmt.sh` before submitting a PR it checks whether the source code needs to be formatted or not and if anything fails run `hack/update-gofmt.sh` to actually format sources**.



Expand Down
2 changes: 1 addition & 1 deletion hack/update-gofmt.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

# Copyright 2014 The Kubernetes Authors.
# Copyright 2023 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion hack/verify-gofmt.sh
100644 → 100755
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

# Copyright 2021 The Kubernetes Authors.
# Copyright 2023 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down

0 comments on commit dee4f48

Please sign in to comment.