Skip to content

Commit

Permalink
fix(ci): extend 'go test' timeout to 20 min (#599)
Browse files Browse the repository at this point in the history
We've had some CI runs fail with timeouts against the EU region: likely
the increased latency just having things take that much longer.

A previous attempt to extend the timeout of the integration test step in
the GHA Workflow forgot that the default timeout for `go test` is 10
minutes 🙃. This extends that to 20 for the provider's integration tests
and adjusts the GHA `timeout-minutes` values (as the default is 360
minutes)

Fly by fix for the "Validate Examples" job which started failing due to
the update to `ubuntu-latest` from what I can tell (which no longer has
`terraform` installed by default)
  • Loading branch information
jharley authored Jan 13, 2025
1 parent 949a33a commit 68897f3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
name: Test US
needs: build
runs-on: ubuntu-latest
timeout-minutes: 20
timeout-minutes: 25
concurrency:
group: hnytf-testacc-us
env:
Expand Down Expand Up @@ -86,6 +86,7 @@ jobs:
TF_ACC_TERRAFORM_VERSION: ${{ env.TERRAFORM_VERSION }}
run: |
go test -v ./internal/... ./honeycombio/... \
-timeout=20m \
-covermode=atomic | \
go-junit-report \
-set-exit-code \
Expand Down Expand Up @@ -124,7 +125,7 @@ jobs:
name: Test EU
needs: build
runs-on: ubuntu-latest
timeout-minutes: 20
timeout-minutes: 25
concurrency:
group: hnytf-testacc-eu
env:
Expand Down Expand Up @@ -179,6 +180,7 @@ jobs:
TF_ACC_TERRAFORM_VERSION: ${{ env.TERRAFORM_VERSION }}
run: |
go test -v ./internal/... ./honeycombio/... \
-timeout=20m \
-covermode=atomic | \
go-junit-report \
-set-exit-code \
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/validate-examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ name: Validate Examples
on:
workflow_dispatch:
push:
paths-ignore:
- README.md
- CHANGELOG.md
- CONTRIBUTING.md

jobs:
validate:
Expand All @@ -25,6 +21,11 @@ jobs:
- name: Build
run: go build -o /tmp/providers/terraform-provider-honeycombio

- name: Setup Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_wrapper: false

- name: Validate examples
env:
TF_IN_AUTOMATION: 1
Expand Down

0 comments on commit 68897f3

Please sign in to comment.