feat(samplers): add deterministic sampler #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaHaddara
changed the title
MustafaHaddara
commented
Jan 23, 2025
| val context = Context.root() | ||
|
|
||
| val sampler = HoneycombDeterministicSampler(args.rate) | ||
| val result = sampler.shouldSample(context, traceId, "test", SpanKind.CLIENT, Attributes.empty(), emptyList<LinkData>().toMutableList()) |
There was a problem hiding this comment.
UNLIKE the Swift PR, here we JUST need a Context instead of a SpanContext. This seems to be a difference in the OTel APIs: the Swift one has a signature:
func shouldSample(
parentContext: SpanContext?,
traceId: TraceId,
name: String,
kind: SpanKind,
attributes: [String: AttributeValue],
parentLinks: [SpanData.Link]
) -> any Decisionwhereas the Android one has the signature
fun shouldSample(
context: Context,
traceId: String,
name: String,
spanKind: SpanKind,
attributes: Attributes,
parentLinks: MutableList<LinkData>
): SamplingResultand there doesn't seem to be a relationship between Context and SpanContext in the Android SDK.
martin308
approved these changes
Jan 24, 2025
Comment on lines
44
to
52
| // private class HoneycombDecision(val decision: SamplingDecision, val attributes: Attributes) : SamplingResult { | ||
| // override fun getDecision(): SamplingDecision { | ||
| // return decision | ||
| // } | ||
| // | ||
| // override fun getAttributes(): Attributes { | ||
| // return attributes | ||
| // } | ||
| // } |
MustafaHaddara
force-pushed
the
mh/deterministic-sampler
branch
from
ee4dac2 to
bf614cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
Adds a deterministic sampler, similar to other Honeycomb distro. Heavily based on honeycombio/honeycomb-opentelemetry-swift#17
That PR never actually used the Sampler; I'm not sure if we need to make changes to HoneycombOptions / somewhere else in the initialization process to actually make use of this.
How to verify that this has the expected result