Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly drop to jdk 17 #30

Merged
merged 3 commits into from
Jan 15, 2025
Merged

chore: explicitly drop to jdk 17 #30

merged 3 commits into from
Jan 15, 2025

Conversation

MustafaHaddara
Copy link
Contributor

@MustafaHaddara MustafaHaddara commented Jan 15, 2025

Which problem is this PR solving?

While working on #24, I noticed Android Studio had updated the compiler config in the .idea directory to drop down to java compiler 17 (instead of 21).

Similarly, I started seeing warnings like

> Task :core:compileDebugJavaWithJavac
Java compiler version 21 has deprecated support for compiling with source/target version 8.
Try one of the following options:
    1. [Recommended] Use Java toolchain with a lower language version
    2. Set a higher source/target version
    3. Use a lower version of the JDK running the build (if you're not using Java toolchain)
For more details on how to configure these settings, see https://developer.android.com/build/jdks.
To suppress this warning, set android.javaCompile.suppressSourceTargetDeprecationWarning=true in gradle.properties.
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
3 warnings

(job link)

The documentation for the CircleCI Android orb implies that Java 17 is the default but clearly it's actually using Java 21.

Short description of the changes

This PR updates our CircleCI config to explicitly use 17, and commits the updated Android Studio config to keep local dev environments in line.

How to verify that this has the expected result

The same job no longer spits out the Java compiler version 21 warning

@MustafaHaddara MustafaHaddara marked this pull request as ready for review January 15, 2025 20:06
@MustafaHaddara MustafaHaddara requested a review from a team as a code owner January 15, 2025 20:06
@MustafaHaddara MustafaHaddara merged commit 57d0fb1 into main Jan 15, 2025
7 checks passed
@MustafaHaddara MustafaHaddara deleted the mh/jdk-17 branch January 15, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants