Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix dev tag on merge to main branch #17

Merged
merged 1 commit into from
Jul 13, 2023
Merged

ci: fix dev tag on merge to main branch #17

merged 1 commit into from
Jul 13, 2023

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Jul 12, 2023 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Add dev tag back to metadata-action step (otherwise it defaults to main as ghcr.io/honeycombio/ebpf-agent:main instead of ghcr.io/honeycombio/ebpf-agent:dev), along with note that indicates its purpose and type
  • Update Build and push to use the tag from the metadata-action step because that ensures it has the full name of the image for ghcr.
    • Failed step shows #32 [auth] library/dev:pull,push token for registry-1.docker.io
    • Successful step shows #25 [auth] honeycombio/ebpf-agent:pull,push token for ghcr.io
  • See details of last successful build on main.
  • See details of last failed build on main.

How to verify that this has the expected result

Next merge to main should properly build and push a dev tag.

@JamieDanielson
add dev tag in metadata-action, use in build-push
cddf4ac 
the failed build and push on main shows
tags: dev
a successful build and push on main shows
ghcr.io/honeycombio/ebpf-agent:dev

https://github.com/marketplace/actions/docker-metadata-action#typeraw
@JamieDanielson JamieDanielson requested a review from a team July 12, 2023 21:25
@JamieDanielson JamieDanielson self-assigned this Jul 12, 2023
@JamieDanielson JamieDanielson added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. no-changelog Omit this PR from changelog/release notes. labels Jul 12, 2023
MikeGoldsmith
MikeGoldsmith approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for fixing this - I was hopeful we didn't need the metadata tags stuff, never mind 🤷🏻

@MikeGoldsmith MikeGoldsmith merged commit 213c71c into main Jul 13, 2023
5 checks passed
@MikeGoldsmith MikeGoldsmith deleted the jamie.fix-main-push branch July 13, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
no-changelog Omit this PR from changelog/release notes. type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieDanielson @MikeGoldsmith