Skip to content

Commit

Permalink
remove erroneous default value (#148)
Browse files Browse the repository at this point in the history
In reworking the commits for the new version, I mistakenly restored a default value for the dataset that shouldn't be there. This removes it. Defaults are now applied in code based on logic.
  • Loading branch information
kentquirk authored Apr 15, 2022
1 parent 8ff3d5c commit 8d07d3d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd_root.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ about your Continuous Integration builds.`,
root.PersistentFlags().Lookup("apikey").Value.Set(apikey)
}

root.PersistentFlags().StringVarP(&cfg.Dataset, "dataset", "d", "buildevents", "[env.BUILDEVENT_DATASET] the name of the Honeycomb dataset to which to send these events")
root.PersistentFlags().StringVarP(&cfg.Dataset, "dataset", "d", "", "[env.BUILDEVENT_DATASET] the name of the Honeycomb dataset to which to send these events")
if dataset, ok := os.LookupEnv("BUILDEVENT_DATASET"); ok {
root.PersistentFlags().Lookup("dataset").Value.Set(dataset)
}
Expand Down

0 comments on commit 8d07d3d

Please sign in to comment.