Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Classic Ingest Key support #295

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: add Classic Ingest Key support #295

merged 1 commit into from
Mar 7, 2024

Conversation

jharley
Copy link
Contributor

@jharley jharley commented Mar 6, 2024 •
edited by MikeGoldsmith
Loading

Which problem is this PR solving?

  • We've now released Ingest Keys, but in order for them to work with Classic environments properly we need to update the key detection logic.

Short description of the changes

  • upgrades libhoney-py to 2.4.0
  • uses libhoney-py's newly exported IsClassicKey function to support Classic Ingest Keys

@jharley jharley added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Mar 6, 2024
@jharley jharley self-assigned this Mar 6, 2024
@jharley jharley requested a review from a team March 6, 2024 21:37
@jharley jharley marked this pull request as ready for review March 6, 2024 21:38
@jharley jharley requested a review from a team as a code owner March 6, 2024 21:38
@jharley jharley merged commit d81bade into main Mar 7, 2024
7 checks passed
@jharley jharley deleted the jharley.fest-classic-ik branch March 7, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brookesargent brookesargent brookesargent approved these changes

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@jharley jharley

Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jharley @MikeGoldsmith @brookesargent