switch the list method to index method for new heroku cli, This resolves #4 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hone any plans to merge this? |
|
Yes, please merge. Took me a while to find this.... |
|
I'll add, even though I now have jwang's herocutter installed I can't install plugins like the following |
|
+1... |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer version of heroku's gem 2.x moved the :list method to :index and is now called via
heroku pluginsinstead ofheroku plugins:listWhen attempting to install herocutter, we get an error message of:
Could not initialize heroku_herocutter: undefined method
list' for classHeroku::Command::Plugins'This patch resolves that issue, which is currently documented as #4.