Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved circular dependency issue in Object extension methods #22

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

zgavin
Copy link
Contributor

@zgavin zgavin commented Mar 10, 2025

When using swc, the allowOverwritingPrototypeExtension constant was undefined at runtime, meaning that nothing which inherited from Object (ie, everything) could be fully stubbed by sinon since writable was then defaulting to false after the defineProperty call.

@zgavin zgavin requested review from stephenh and haislip March 10, 2025 15:05
@zgavin zgavin merged commit e235426 into main Mar 10, 2025
5 checks passed
@zgavin zgavin deleted the fix/object-circular-imports branch March 10, 2025 15:42
@homebound-team-bot
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants