Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add-on rebuild with ingress #4819

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix add-on rebuild with ingress #4819

merged 1 commit into from
Jan 15, 2024

Conversation

agners
Copy link
Member

@agners agners commented Jan 15, 2024 •
edited
Loading

Proposed change

Add-ons which use ingress fail to start after rebuild because the ingress port doesn't get set properly. Make sure to set the ingress port after rebuild.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@agners
Fix add-on rebuild with ingress
645ce69 
Add-ons which use ingress fail to start after rebuild because the
ingress port doesn't get set properly. Make sure to set the ingress
port after rebuild.

Fixes: #4807
@agners agners added the bugfix A bug fix label Jan 15, 2024
@bdraco
Copy link
Member

bdraco commented Jan 15, 2024

I'll patch my production and test in a few hours after I get moving for the day

@bdraco
Copy link
Member

bdraco commented Jan 15, 2024

Thanks!

bdraco
bdraco approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuilt a few times, confirmed fixed

@bdraco bdraco merged commit 98c01fe into main Jan 15, 2024
24 checks passed
@bdraco bdraco deleted the fix-addon-rebuild-with-ingress branch January 15, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
bugfix A bug fix cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESPHome Dev addon triggers raising RuntimeError when checking ingress_port
2 participants
@agners @bdraco