Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DA] added cancel all timer and test, and change of default wording for timer #2816

Merged
merged 27 commits into from
Jan 20, 2025
Merged

[DA] added cancel all timer and test, and change of default wording for timer #2816

merged 27 commits into from
Jan 20, 2025

Conversation

kimvonmullen
Copy link
Contributor

[DA] added cancel all timer and test

@kimvonmullen kimvonmullen requested a review from MTrab as a code owner January 1, 2025 17:59
MTrab
MTrab approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@MTrab MTrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MTrab MTrab self-requested a review January 2, 2025 09:05
kimvonmullen and others added 4 commits January 4, 2025 12:34
@MTrab MTrab self-requested a review January 10, 2025 12:05
@kimvonmullen kimvonmullen changed the title [DA] added cancel all timer and test [DA] added cancel all timer and test, and change of default wording for timer Jan 10, 2025
@kimvonmullen kimvonmullen marked this pull request as draft January 10, 2025 12:17
@kimvonmullen kimvonmullen marked this pull request as ready for review January 10, 2025 14:18
@kimvonmullen
Copy link
Contributor Author

Hi @MTrab ,it should now be ok, there was some missing and I just had to get use to the pull request process

MTrab
MTrab approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@MTrab MTrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if the build succeeds this time

tests/da/tests/da/homeassistant_HassCancelTimer.yaml Outdated Show resolved Hide resolved
@kimvonmullen
Copy link
Contributor Author

Hi @MTrab , it should all be good now.

@MTrab
Copy link
Contributor

MTrab commented Jan 17, 2025

Sorry but no - guess you have some missing blank lines at the end of some files.
The build fails on the prettier step that checks the file syntax

MTrab
MTrab requested changes Jan 17, 2025
View reviewed changes
responses/da/HassCancelAllTimers.yaml Show resolved Hide resolved
sentences/da/_common.yaml Outdated Show resolved Hide resolved
sentences/da/homeassistant_HassCancelAllTimers.yaml Outdated Show resolved Hide resolved
sentences/da/homeassistant_HassCancelTimer.yaml Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 17, 2025 15:28
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MTrab
Copy link
Contributor

MTrab commented Jan 17, 2025

Still errors out for the test file - must be some error in that file

@MTrab MTrab marked this pull request as ready for review January 20, 2025 19:29
@home-assistant home-assistant bot requested a review from MTrab January 20, 2025 19:29
@MTrab MTrab merged commit 480095f into home-assistant:main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MTrab MTrab MTrab approved these changes

Assignees
No one assigned
Labels
cla-signed lang: da
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimvonmullen @MTrab @Dawn3888