Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reddit Integration: allow fetching user posts #34345

Conversation

NicolasNewman
Copy link

@NicolasNewman NicolasNewman commented Aug 18, 2024

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Updated to a new version of the ruby-lsp gem for improved performance and minor feature enhancements.
    • Added a new term "Custom integration" to the glossary for better understanding of community-created integrations.
    • Introduced new configuration option redditors for Reddit integrations to specify user data collection.
  • Bug Fixes

    • Various documentation links updated to enhance navigation and accuracy, particularly regarding action references.
  • Documentation

    • Enhanced clarity and consistency in multiple integration documentation related to configuration files and action links.
    • Added new sections in the documentation for supported devices in several integrations.
  • Chores

    • Updated redirect paths for documentation links to reflect new organizational structure.

c0ffeeca7 and others added 30 commits August 8, 2024 09:49
…ant#34193)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Clarification for raw tip voltage sensor, add ha category

* add comma
…t#34217)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…34218)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…34216)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Closing quote missing from the template
home-assistant#34244)

* Update IMAP docs on use of App passwords and removed Microsoft support

* Suggested update

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Tiny tweak

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <[email protected]>
…e-assistant#34251)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…34250)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#34252)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Link to all entities that is support in group

Link to all entities that are currently supported in a group

* tiny tweak

---------

Co-authored-by: c0ffeeca7 <[email protected]>
…tant#34257)

* Cleanup mqtt publish action template option documentation

* Missed instance
Copy link
Contributor

coderabbitai bot commented Aug 18, 2024

Walkthrough

Walkthrough

The recent updates primarily focus on enhancing documentation, refining configuration settings, and updating dependencies within the Home Assistant project. Notable changes include a minor version increment for the ruby-lsp gem, the addition of new entries in the glossary, and various improvements across multiple integration documents. These modifications aim to improve user accessibility and clarity while ensuring the system remains up-to-date with the latest features and fixes.

Changes

Files Change Summary
Gemfile Updated ruby-lsp gem from version 0.17.11 to 0.17.13.
_config.yml Incremented current_patch_version from 0 to 2 and updated date_released to 2024-08-16.
plugins/details.rb Removed JavaScript function for content visibility; replaced with HTML <details> and <summary> elements.
sass/homeassistant/plugins/_details.scss Enhanced styles for .details-block based on the open state with .up and .down classes.
source/_data/glossary.yml Added new term "Custom integration"; updated links for "Integrations" and "Service".
source/_docs/blueprint/tutorial.markdown Updated link for turn_on and turn_off actions to point to "perform actions".
source/_docs/scripts.markdown Updated actions page link to new documentation section.
source/_includes/asides/docs_sitemap.html Changed documentation sitemap link for actions from service-calls to perform-actions.
source/_includes/installation/core.md Reformatted "Prerequisites" section and added troubleshooting note.
source/_integrations/androidtv_remote.markdown Updated action types from call-service to perform-action for buttons.
source/_integrations/bluetooth.markdown Added new related resources.
source/_integrations/calendar.markdown Updated links for actions documentation.
source/_integrations/config.markdown Introduced new related section.
source/_integrations/conversation.markdown Updated URL for response data in conversation actions.
source/_integrations/device_tracker.markdown Clarified example reference to configuration.yaml file.
source/_integrations/dhcp.markdown Clarified configuration instructions regarding configuration.yaml.
source/_integrations/easyenergy.markdown Updated action URLs for energy and gas price exposure.
source/_integrations/emulated_hue.markdown Clarified that configuration entries should be added to configuration.yaml.
source/_integrations/flux.markdown Added default values for start_time ("sunrise") and stop_time ("dusk").
source/_integrations/frontend.markdown Improved references to configuration.yaml.
source/_integrations/generic_hygrostat.markdown Enhanced clarity regarding configuration.yaml.
source/_integrations/google_generative_ai_conversation.markdown Updated URL for "Response Data" section.
source/_integrations/group.markdown Expanded group integration documentation for entity grouping capabilities.
source/_integrations/homeassistant.markdown Updated formatting of configuration.yaml references.
source/_integrations/homeassistant_alerts.markdown Clarified reference to default_config: in configuration.yaml.
source/_integrations/http.markdown Clarified context of a configuration entry.
source/_integrations/imap.markdown Added new subsection for Microsoft 365 and Live IMAP services authentication.
source/_integrations/input_boolean.markdown Minor textual modification for clarity.
source/_integrations/input_datetime.markdown Minor textual modifications for clarity.
source/_integrations/iron_os.markdown Added "Minimum requirements" section and updated ha_category.
source/_integrations/light.template.markdown Clarified references to configuration.yaml file.
source/_integrations/logbook.markdown Added new related section with reference to configuration file documentation.
source/_integrations/matter.markdown Updated section header to "Matter OTA device updates."
source/_integrations/motionblinds_ble.markdown Updated URL for homeassistant.update_entity action.
source/_integrations/mqtt.markdown Removed section on "MQTT Notifications."
source/_integrations/openai_conversation.markdown Updated URL for "Response Data" section.
source/_integrations/python_script.markdown Updated references to response_variable in documentation.
source/_integrations/qbittorrent.markdown Updated documentation links for qbittorrent actions.
source/_integrations/reddit.markdown Added new redditors field for Reddit sensor configuration.
source/_integrations/reolink.markdown Updated password requirements and supported models information.
source/_integrations/rest_command.markdown Corrected hyperlink for accessing response_variable.
source/_integrations/roomba.markdown Clarified default behavior of continuous mode feature.
source/_integrations/russound_rio.markdown Added "Supported devices" section.
source/_integrations/sensor.mqtt.markdown Corrected formatting of string in value_template field.
source/_integrations/shell_command.markdown Updated URL for response_variable in shell commands.
source/_integrations/shelly.markdown Updated firmware version requirements for Shelly devices.
source/_integrations/swiss_public_transport.markdown Changed configuration parameter description from "start station" to "end station" and removed old parameter.
source/_integrations/system_bridge.markdown Updated documentation links to point to new "perform-actions" section.
source/_integrations/template.markdown Altered URLs in action descriptions and example sections.
source/_integrations/tibber.markdown Updated URL path for actions documentation.
source/_integrations/todo.markdown Minor updates to formatting and hyperlink structure in documentation.
source/_integrations/wake_on_lan.markdown Changed "switch" to "button" in description of functionality.
source/_integrations/waze_travel_time.markdown Updated hyperlink reference for waze_travel_time.get_travel_times action.
source/_integrations/weather.markdown Modified URL for the response data reference in weather.get_forecasts.
source/_integrations/wled.markdown Expanded WLED functionality description to include SPI-based chipset support.
source/_integrations/workday.markdown Updated URL link for the "Response Data" section in workday.check_date action.
source/_integrations/zha.markdown Updated hyperlink for binding and unbinding functionality in ZHA documentation.
source/_posts/2024-08-07-release-20248.markdown Added section for "Patch releases" detailing updates for versions 2024.8.1 and 2024.8.2.
source/_posts/2024-08-08-works-with-home-assistant-becomes-part-ohf.markdown Introduced blog post regarding the transition of "Works with Home Assistant" to the Open Home Foundation.
_redirects Modified redirect paths for documentation links from service-calls to perform-actions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 15

Outside diff range, codebase verification and nitpick comments (13)
source/_integrations/reddit.markdown (1)

68-71: Documentation for redditors field lacks examples and detailed guidance.

The current documentation only provides a basic description of the redditors field without any examples or further guidance on its usage. Please update the documentation to include clear examples and instructions.

  • The redditors field is described as a list of users you want to get data on, but no examples are provided.
Analysis chain

Verify documentation and examples for redditors field.

Ensure that the documentation provides clear examples and guidance on using the new redditors field effectively.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify documentation for the new `redditors` field.

# Test: Search for examples and guidance related to the `redditors` field in the documentation. Expect: Clear and comprehensive documentation.
rg --type markdown 'redditors'

Length of output: 130


Script:

#!/bin/bash
# Extract more context around the occurrences of "redditors" in markdown files to verify documentation and examples.
rg --type markdown 'redditors' -A 5 -B 5

Length of output: 1355

source/_integrations/logbook.markdown (1)

17-17: Add alt text to improve accessibility.

The image should have alternate text to improve accessibility for users with visual impairments.

- <img src='/images/screenshots/logbook.png' style='margin-left:10px; float: right;' height="100" />
+ <img src='/images/screenshots/logbook.png' alt='Logbook screenshot' style='margin-left:10px; float: right;' height="100" />
Tools
Markdownlint

17-17: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

source/_posts/2024-08-08-works-with-home-assistant-becomes-part-ohf.markdown (1)

39-39: Consider adding a comma after the introductory phrase.

Adding a comma after "From now on" can improve readability by clearly separating the introductory phrase from the main clause.

- From now on the program will be certifying individual devices instead of whole brands.
+ From now on, the program will be certifying individual devices instead of whole brands.
Tools
LanguageTool

[typographical] ~39-~39: Consider adding a comma after this introductory phrase.
Context: ...proving the program on several fronts. From now on the program will be certifying individu...

(FROM_NOW_ON_COMMA)

source/voice_control/thirteen-usd-voice-remote.markdown (1)

98-98: Consider using a comma before 'and'.

Adding a comma before "and" can improve readability by clearly separating the independent clauses.

- for Assist to find you're done speaking and it can start processing your command.
+ for Assist to find you're done speaking, and it can start processing your command.
Tools
LanguageTool

[uncategorized] ~98-~98: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... for Assist to find you're done speaking and it can start processing your command. ...

(COMMA_COMPOUND_SENTENCE)

source/_integrations/wled.markdown (3)

108-108: Ensure complete sentences by including a subject.

To form a complete sentence, consider adding "It" at the beginning.

- Toggles the WLED Timer.
+ It toggles the WLED Timer.
Tools
LanguageTool

[style] ~108-~108: To form a complete sentence, be sure to include a subject.
Context: ...### Nightlight Toggles the WLED Timer. Can be configured on the WLED itself under ...

(MISSING_IT_THERE)


114-114: Ensure complete sentences by including a subject.

To form a complete sentence, consider adding "It" at the beginning.

- Toggles the synchronization between multiple WLED devices.
+ It toggles the synchronization between multiple WLED devices.
Tools
LanguageTool

[style] ~114-~114: To form a complete sentence, be sure to include a subject.
Context: ...nization between multiple WLED devices. Can be configured on the WLED itself under ...

(MISSING_IT_THERE)


115-115: Remove trailing spaces.

There are trailing spaces at the end of this line. Removing them can improve code cleanliness.

- Can be configured on the WLED itself under 
+ Can be configured on the WLED itself under
Tools
Markdownlint

115-115: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

source/_integrations/conversation.markdown (1)

169-169: Consider using "can" instead of "is able to".

For a more concise expression, consider using "can return" instead of "is able to return".

- This action is able to return [response data](/docs/scripts/perform-actions/#use-templates-to-handle-response-data).
+ This action can return [response data](/docs/scripts/perform-actions/#use-templates-to-handle-response-data).
Tools
LanguageTool

[style] ~169-~169: As a shorter alternative for ‘able to’, consider using “can”.
Context: ... | This action is able to return [response data](/docs/scripts/pe...

(BE_ABLE_TO)

source/_integrations/todo.markdown (1)

48-48: Consider adding a comma before "or".

To improve readability, consider adding a comma before "or" as it connects two independent clauses.

- actions provided by some to-do list entities are described below or you can read more about [actions](/docs/scripts/perform-actions/).
+ actions provided by some to-do list entities are described below, or you can read more about [actions](/docs/scripts/perform-actions/).
Tools
LanguageTool

[uncategorized] ~48-~48: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... to-do list entities are described below or you can read more about [actions](/docs...

(COMMA_COMPOUND_SENTENCE)

source/_integrations/calendar.markdown (1)

145-145: Consider adding a comma before "or".

To improve readability, consider adding a comma before "or" as it connects two independent clauses.

- The actions provided by some calendar {% term entity %} are described below or you can read more about [actions](/docs/scripts/perform-actions/).
+ The actions provided by some calendar {% term entity %} are described below, or you can read more about [actions](/docs/scripts/perform-actions/).
Tools
LanguageTool

[uncategorized] ~145-~145: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...ar {% term entity %} are described below or you can read more about [actions](/docs...

(COMMA_COMPOUND_SENTENCE)

source/_integrations/homeassistant.markdown (1)

215-215: Simplify phrasing.

Consider simplifying the phrasing by using "inside" instead of "inside of."

- inside of `homeassistant:`
+ inside `homeassistant:`
Tools
LanguageTool

[style] ~215-~215: This phrase is redundant. Consider using “inside”.
Context: ... %} file, you must make sure it is done inside of homeassistant: or it will fail. {% en...

(OUTSIDE_OF)

source/_integrations/reolink.markdown (1)

38-39: Clarify Password Requirements.

The addition specifying allowed characters in Reolink passwords is a helpful clarification. Consider rephrasing for better readability.

- The password used for the Reolink device can only contain characters `a-z, A-Z, 0-9 or @$*~_-+=!?.,:;'()[]`.
+ The password for the Reolink device can only include the following characters: `a-z, A-Z, 0-9, @$*~_-+=!?.,:;'()[]`.
Tools
LanguageTool

[formatting] ~39-~39: Did you mean “?”
Context: ...link device can only contain characters a-z, A-Z, 0-9 or @$*~_-+=!?.,:;'()[]. Other special characters will...

(MULTIPLE_PUNCTATION_MARKS_1)

source/_integrations/mqtt.markdown (1)

Line range hint 1088-1114: Add a comma for clarity.

Consider adding a comma after "editor" for improved readability.

- If you want to send JSON using the YAML editor then you need to format/escape it properly.
+ If you want to send JSON using the YAML editor, then you need to format/escape it properly.
Tools
LanguageTool

[typographical] ~1114-~1114: Consider adding a comma.
Context: ... want to send JSON using the YAML editor then you need to format/escape it properly. ...

(IF_THEN_COMMA)

Comment on lines +325 to +334
## Matter OTA device updates

The Matter standard supports OTA (Over-the-Air) updates optionally. Matter devices that support Matter updates will have an [update entity](/integrations/update). Furthermore, the CSA DCL (Distributed Compliance Ledger) stores firmware update information. Home Assistant reads firmware update information directly from the DCL to learn about available updates. By default, the integration checks every 12 hours for an update. If you want to force an update check, use the `homeassistant.update_entity` [action](/integrations/homeassistant/) with the update entity as the target.
The Matter protocol supports OTA (Over-the-Air) software updates. But the OTA software update is an optional feature for Matter devices, so not all Matter devices implement it. Home Assistant creates an update entity for every Matter device which does support Matter updates.

The CSA operates a Distributed Compliance Ledger (DCL) which provides metadata for firmware updates. By default, the Matter update entities check the DCL every 12 hours for updates. If you want to force an update check, use the `homeassistant.update_entity` [action](/integrations/homeassistant/), with the update entity as the target. Currently, Eve and Nanoleaf are using the DCL to provide updates. It is expected that in future, more and more firmware updates become available through the DCL.

<p class='img'>
<img src='/images/integrations/matter/matter_ota_message.png' alt='Matter device OTA update message'>
Notification of an OTA update for a Matter device
</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify language consistency for international audiences.

The phrase "in future" is British English. Consider using "in the future" for consistency with American English, which is more commonly used in technical documentation.

- It is expected that in future, more and more firmware updates become available through the DCL.
+ It is expected that in the future, more and more firmware updates become available through the DCL.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Matter OTA device updates
The Matter standard supports OTA (Over-the-Air) updates optionally. Matter devices that support Matter updates will have an [update entity](/integrations/update). Furthermore, the CSA DCL (Distributed Compliance Ledger) stores firmware update information. Home Assistant reads firmware update information directly from the DCL to learn about available updates. By default, the integration checks every 12 hours for an update. If you want to force an update check, use the `homeassistant.update_entity` [action](/integrations/homeassistant/) with the update entity as the target.
The Matter protocol supports OTA (Over-the-Air) software updates. But the OTA software update is an optional feature for Matter devices, so not all Matter devices implement it. Home Assistant creates an update entity for every Matter device which does support Matter updates.
The CSA operates a Distributed Compliance Ledger (DCL) which provides metadata for firmware updates. By default, the Matter update entities check the DCL every 12 hours for updates. If you want to force an update check, use the `homeassistant.update_entity` [action](/integrations/homeassistant/), with the update entity as the target. Currently, Eve and Nanoleaf are using the DCL to provide updates. It is expected that in future, more and more firmware updates become available through the DCL.
<p class='img'>
<img src='/images/integrations/matter/matter_ota_message.png' alt='Matter device OTA update message'>
Notification of an OTA update for a Matter device
</p>
## Matter OTA device updates
The Matter protocol supports OTA (Over-the-Air) software updates. But the OTA software update is an optional feature for Matter devices, so not all Matter devices implement it. Home Assistant creates an update entity for every Matter device which does support Matter updates.
The CSA operates a Distributed Compliance Ledger (DCL) which provides metadata for firmware updates. By default, the Matter update entities check the DCL every 12 hours for updates. If you want to force an update check, use the `homeassistant.update_entity` [action](/integrations/homeassistant/), with the update entity as the target. Currently, Eve and Nanoleaf are using the DCL to provide updates. It is expected that in the future, more and more firmware updates become available through the DCL.
<p class='img'>
<img src='/images/integrations/matter/matter_ota_message.png' alt='Matter device OTA update message'>
Notification of an OTA update for a Matter device
</p>
Tools
LanguageTool

[locale-violation] ~329-~329: The phrase ‘in future’ is British English. Did you mean: “in the future”?
Context: ...to provide updates. It is expected that in future, more and more firmware updates become ...

(IN_FUTURE)


```text
https://github.com/home-assistant/operating-system/releases/download/{{site.data.version_data.hassos[variant.key]}}/haos_{{ variant.key }}-{{site.data.version_data.hassos[variant.key]}}.img.xz
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing spaces for markdown compliance.

Trailing spaces in the URL section should be removed to adhere to markdown standards.

-    ```    
+    ```
Tools
Markdownlint

90-90: Expected: 0 or 2; Actual: 4
Trailing spaces

(MD009, no-trailing-spaces)

Comment on lines +61 to +63
- [Patch releases](#patch-releases)
- [2024.8.1 - August 10](#202481---august-10)
- [2024.8.2 - August 16](#202482---august-16)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add commas for date formatting.

Add commas to separate the day and year in the date format for consistency.

- 2024.8.1 - August 10
+ 2024.8.1 - August 10,
- 2024.8.2 - August 16
+ 2024.8.2 - August 16,
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [Patch releases](#patch-releases)
- [2024.8.1 - August 10](#202481---august-10)
- [2024.8.2 - August 16](#202482---august-16)
- [Patch releases](#patch-releases)
- [2024.8.1 - August 10,](#202481---august-10)
- [2024.8.2 - August 16,](#202482---august-16)
Tools
LanguageTool

[uncategorized] ~62-~62: Commas set off the year in a month-day-year date.
Context: ...eases](#patch-releases) - 2024.8.1 - August 10 - [2024.8.2 - A...

(MISSING_COMMA_BETWEEN_DAY_AND_YEAR)

- Fix error message in html5 ([@mib1185] - [#123749])
- Bump py-nextbusnext to 2.0.4 ([@ViViDboarder] - [#123750])
- Bump python-nest-sdm to 4.0.6 ([@allenporter] - [#123762])
- Update xknx to 3.1.0 and fix climate read only mode ([@farmio] - [#123776])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a hyphen for compound adjectives.

The term "read only" should be hyphenated to "read-only" when used as an adjective.

- fix climate read only mode
+ fix climate read-only mode
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Update xknx to 3.1.0 and fix climate read only mode ([@farmio] - [#123776])
- Update xknx to 3.1.0 and fix climate read-only mode ([@farmio] - [#123776])
Tools
LanguageTool

[uncategorized] ~729-~729: The adjective “read-only” is spelled with a hyphen.
Context: ... - Update xknx to 3.1.0 and fix climate read only mode ([@farmio] - [#123776]) - Fix KNX ...

(READ_ONLY_ACCESS_HYPHEN)

[#122479]: https://github.com/home-assistant/core/pull/122479
[#123276]: https://github.com/home-assistant/core/pull/123276
[#123454]: https://github.com/home-assistant/core/pull/123454
[#123544]: https://github.com/home-assistant/core/pull/123544
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused link reference definition: "#123544".

The link reference definition is not used in the document and should be removed to avoid confusion.

- [#123544]: https://github.com/home-assistant/core/pull/123544
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[#123544]: https://github.com/home-assistant/core/pull/123544
Tools
Markdownlint

1300-1300: Unused link or image reference definition: "#123544"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

[@edenhaus]: https://github.com/edenhaus
[@emontnemery]: https://github.com/emontnemery
[@farmio]: https://github.com/farmio
[@frenck]: https://github.com/frenck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate link reference definition: "@frenck".

The link reference definition is duplicated and should be removed to avoid redundancy.

- [@frenck]: https://github.com/frenck
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[@frenck]: https://github.com/frenck
Tools
Markdownlint

1359-1359: Duplicate link or image reference definition: "@frenck"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

[@joostlek]: https://github.com/joostlek
[@kingy444]: https://github.com/kingy444
[@miaucl]: https://github.com/miaucl
[@mib1185]: https://github.com/mib1185
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate link reference definition: "@mib1185".

The link reference definition is duplicated and should be removed to avoid redundancy.

- [@mib1185]: https://github.com/mib1185
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[@mib1185]: https://github.com/mib1185
Tools
Markdownlint

1366-1366: Duplicate link or image reference definition: "@mib1185"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

[@alengwenus]: https://github.com/alengwenus
[@allenporter]: https://github.com/allenporter
[@autinerd]: https://github.com/autinerd
[@bdraco]: https://github.com/bdraco
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate link reference definition: "@bdraco".

The link reference definition is duplicated and should be removed to avoid redundancy.

- [@bdraco]: https://github.com/bdraco

Committable suggestion was skipped due to low confidence.

Tools
Markdownlint

1352-1352: Duplicate link or image reference definition: "@bdraco"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


[#114628]: https://github.com/home-assistant/core/pull/114628
[#122479]: https://github.com/home-assistant/core/pull/122479
[#123276]: https://github.com/home-assistant/core/pull/123276
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate link reference definition: "#123276".

The link reference definition is duplicated and should be removed to avoid redundancy.

- [#123276]: https://github.com/home-assistant/core/pull/123276
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[#123276]: https://github.com/home-assistant/core/pull/123276
Tools
Markdownlint

1298-1298: Duplicate link or image reference definition: "#123276"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

[#124027]: https://github.com/home-assistant/core/pull/124027
[#124041]: https://github.com/home-assistant/core/pull/124041
[#124047]: https://github.com/home-assistant/core/pull/124047
[@Bre77]: https://github.com/Bre77
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate link reference definition: "@Bre77".

The link reference definition is duplicated and should be removed to avoid redundancy.

- [@Bre77]: https://github.com/Bre77
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[@Bre77]: https://github.com/Bre77
Tools
Markdownlint

1343-1343: Duplicate link or image reference definition: "@Bre77"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and remove all unreleated commits, target against next. You could start with a fresh branch and PR as a lot of codeowners are tagged.

@home-assistant home-assistant bot marked this pull request as draft August 18, 2024 11:44
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@NicolasNewman
Copy link
Author

NicolasNewman commented Aug 18, 2024

Please rebase and remove all unreleated commits, target against next. You could start with a fresh branch and PR as a lot of codeowners are tagged.

Sorry about that! I'll re-open it shortly

Fixed: #34352

@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@NicolasNewman NicolasNewman deleted the integration/reddit/user-fetch branch August 25, 2024 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.