Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert solaredge to asyncio with aiosolaredge #115599

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Convert solaredge to asyncio with aiosolaredge #115599

merged 3 commits into from
Apr 23, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 14, 2024

Proposed change

The underlying library solaredge did not have a timeout on the requests calls which meant it could hang indefinitely and triggers the 300s safety timeout during startup.
Screenshot 2024-04-14 at 12 09 45 PM
https://docs.astral.sh/ruff/rules/request-without-timeout/

The upstream lib seems abandoned so there didn't seem to be any hope of getting this problem fixed - issue from 2018 so I wrote a new typed lib with coverage and nearly the same API (coros instead of normal functions, and it takes care of the datetime conversions) as the integration only needed a few simple endpoints https://github.com/bdraco/aiosolaredge

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (solaredge) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of solaredge can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign solaredge Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member Author

bdraco commented Apr 14, 2024

Verified all the graphs continue as expected

The drop out is when the timeout issue happened
Screenshot 2024-04-14 at 4 21 41 PM

@bdraco bdraco marked this pull request as ready for review April 14, 2024 21:47
@bdraco bdraco requested a review from frenck as a code owner April 14, 2024 21:47
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Seems to be still OK on this end too.

../Frenck

@frenck frenck merged commit fd08b72 into dev Apr 23, 2024
38 checks passed
@frenck frenck deleted the solar_edge branch April 23, 2024 20:07
@bdraco
Copy link
Member Author

bdraco commented Apr 23, 2024

Thanks, and thanks for testing

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solaredge hangs startup when requests fail to timeout
2 participants