Convert solaredge to asyncio with aiosolaredge #115599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The underlying library
solaredge
did not have a timeout on the requests calls which meant it could hang indefinitely and triggers the 300s safety timeout during startup.https://docs.astral.sh/ruff/rules/request-without-timeout/
The upstream lib seems abandoned so there didn't seem to be any hope of getting this problem fixed - issue from 2018 so I wrote a new typed lib with coverage and nearly the same API (coros instead of normal functions, and it takes care of the datetime conversions) as the integration only needed a few simple endpoints https://github.com/bdraco/aiosolaredge
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: