-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-kasa to 0.5.4 for tplink #103038
Conversation
Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this on production and got
2023-10-29 19:33:06.230 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry TP-LINK_Power Strip_5C33 HS300(US) for tplink
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 399, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/tplink/__init__.py", line 94, in async_setup_entry
found_mac = dr.format_mac(device.mac)
^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/kasa/smartdevice.py", line 86, in wrapped
raise SmartDeviceException(
kasa.exceptions.SmartDeviceException: You need to await update() to access the data
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I'm traveling so I can't do live debugging but when I get back home tomorrow I can dig in more (or Tuesday if I'm too jet lagged) |
confirmed the issue on my dev install as well now that I'm home. debugging.....
|
My test branch was dirty. When I reset it and removed prior changes, the problem went away. Sorry for the side trip. |
The problem is actually in I will send a PR to fix it |
|
Thanks @rytilahti |
Proposed change
This bumps python-kasa to the newest maintenance release which contains variety of reliability improvements which may fix some of the linked issues. In addition, pydantic v2 (c.f., #99218) support is also included.
Full changelog: https://github.com/python-kasa/python-kasa/releases/tag/0.5.4
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: