-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Pydantic wheels with old Cython #101976
Conversation
@@ -179,6 +179,7 @@ jobs: | |||
|
|||
touch requirements_old-cython.txt | |||
cat homeassistant/package_constraints.txt | grep 'grpcio==' >> requirements_old-cython.txt | |||
cat homeassistant/package_constraints.txt | grep 'pydantic==' >> requirements_old-cython.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get a comment above like we have for grpcio referencing the issue
We should merge this, but this won't actually fix it because we have wheels for 1.10.13 up on wheels already that were built with the wrong cython. After this merges we need to:
|
Why would we do that? As in, we can't bump pydantic, as we have to take into account Core installation methods? ../Frenck |
This change would get v1 updates unblocked for all the other install methods. core remains broken for new installs (see below for more details and limitations) and still has to wait for either pydantic issue 7689 to get fixed or for us to switch to pydantic 2.x when all the libraries are ready. Backstory:
|
f980652
to
cf18f3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @joostlek 👍
../Frenck
Proposed change
Build Pydantic wheels with old Cython.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: