Skip to content

Commit

Permalink
Allow empty trigger sentence responses in conversations (#131849)
Browse files Browse the repository at this point in the history
allow empty trigger sentence responses
  • Loading branch information
mib1185 authored Nov 28, 2024
1 parent 8862c5c commit 1a9ab07
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion homeassistant/components/assist_pipeline/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ async def recognize_intent(
:= await conversation.async_handle_sentence_triggers(
self.hass, user_input
)
):
) is not None:
# Sentence trigger matched
trigger_response = intent.IntentResponse(
self.pipeline.conversation_language
Expand Down
10 changes: 7 additions & 3 deletions tests/components/conversation/test_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,12 +236,17 @@ async def test_prepare_agent(
assert len(mock_prepare.mock_calls) == 1


async def test_async_handle_sentence_triggers(hass: HomeAssistant) -> None:
@pytest.mark.parametrize(
("response_template", "expected_response"),
[("response {{ trigger.device_id }}", "response 1234"), ("", "")],
)
async def test_async_handle_sentence_triggers(
hass: HomeAssistant, response_template: str, expected_response: str
) -> None:
"""Test handling sentence triggers with async_handle_sentence_triggers."""
assert await async_setup_component(hass, "homeassistant", {})
assert await async_setup_component(hass, "conversation", {})

response_template = "response {{ trigger.device_id }}"
assert await async_setup_component(
hass,
"automation",
Expand All @@ -260,7 +265,6 @@ async def test_async_handle_sentence_triggers(hass: HomeAssistant) -> None:

# Device id will be available in response template
device_id = "1234"
expected_response = f"response {device_id}"
actual_response = await async_handle_sentence_triggers(
hass,
ConversationInput(
Expand Down

0 comments on commit 1a9ab07

Please sign in to comment.