Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump firmware to Gecko SDK 4.4.4 #129

Closed

Conversation

BreiteSeite
Copy link

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BreiteSeite

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 31, 2024 15:52
Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for home-assistant-skyconnect ready!

Name Link
🔨 Latest commit e4a2fbb
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-skyconnect/deploys/66faf7482909ce0008c2afa4
😎 Deploy Preview https://deploy-preview-129--home-assistant-skyconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

},
{
"name": "Multi-PAN (RCP)",
"url": "https://raw.githubusercontent.com/NabuCasa/silabs-firmware/main/RCPMultiPAN/beta/NabuCasa_SkyConnect_RCP_v4.3.2_rcp-uart-hw-802154_460800.gbl",
"url": "https://raw.githubusercontent.com/NabuCasa/silabs-firmware/main/RCPMultiPAN/beta/NabuCasa_SkyConnect_RCP_v4.4.0_rcp-uart-hw-802154_460800.gbl",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-PAN is locked at 4.3.2 and we aren't going to be updating it for the foreseeable future, despite the firmware builder releases containing newer firmwares.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know. I did not know this. Is this fact documented somewhere (would be also interested in the reason)? If yes, can you point me to that documentation?

(If we would use JSON5 we could add a comment to the manifest.json so future version bumpers don't make the same mistake. Alternatively we could add a special key to that object like "_doc": "This version is pinned and should never be changed. See <doc link>". Not sure if this would break the frontend though (haven't checked).

I amended my commit to exclude the Multi-PAN changes. :)

Thanks for your help on my PR!

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 31, 2024
@github-actions github-actions bot closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants