Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for custom component InelsForHass over xml-rpc #6425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhoralek
Copy link

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @jhoralek 👋

Thanks for opening a pull request. It looks like these are modified logos, as I couldn't find any reference/occurance of iNels using XML-RPC in their branding. Is that correct?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 24, 2025 07:37
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jhoralek
Copy link
Author

jhoralek commented Jan 24, 2025

Hi @frenck,

you are correct. These are modified logos of iNels. This project is based on xml-rpc protocol.

The InelsForHass project is my attempt to make the iNels proprietary solution available.

They have been trying to create a core integration for some time, which I helped them with in the beginning.
The InelsForHass project has been accessible via HACS for a long time and I would like to have a logo there as well.

That's why I modified it so that it could somehow not damage their copyright.

Kind regards

JH

@jhoralek jhoralek marked this pull request as ready for review January 26, 2025 08:14
@home-assistant home-assistant bot requested a review from frenck January 26, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants