Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logos and icons for the dr_park custom integration #6403

Closed
wants to merge 3 commits into from

Conversation

googleweb
Copy link
Contributor

@googleweb googleweb commented Jan 21, 2025

Proposed change

Add logos and icons for the dr_park custom integration(my private integration).

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Contributor Author

@googleweb googleweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, and it's ok.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @googleweb 👋

I could not find the public repository providing this custom integration. Could you please point me to it?

Thanks 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 21, 2025 11:37
Copy link
Contributor Author

@googleweb googleweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry , the public repository url

@googleweb googleweb marked this pull request as ready for review January 21, 2025 11:45
@home-assistant home-assistant bot requested a review from frenck January 21, 2025 11:45
@googleweb
Copy link
Contributor Author

googleweb commented Jan 21, 2025

Sorry , the public repository url
Thank you very much.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't able to find the manufacturer information from this custom integration. Can you point me to the manufacturer/devices this integration integrates with?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 21, 2025 13:15
@googleweb googleweb closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants