Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for Trafikmeldinger custom integration #6366

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

kgn3400
Copy link
Contributor

@kgn3400 kgn3400 commented Jan 15, 2025

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/kgn3400/trafikmeldinger

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Sorry, something went wrong.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @kgn3400 👋

The information data provider used by this integration is DR:

https://www.dr.dk/

I would have expected their branding to be used in this case?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 19, 2025 18:48
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@kgn3400
Copy link
Contributor Author

kgn3400 commented Jan 21, 2025

Hi @frenck 🙂,

www.dr.dk is the public service platform for TV, radio, news, sports, and traffic updates, etc here in Denmark. Their logo/branding is therefore generic to cover all the areas they represent:

image

My user integration only forwards traffic update information from www.dr.dk. Therefore, I would like my user integration icon to clearly communicate to the end user that this is only related to traffic updates.

Best regards
Kurt G. Nielsen

@kgn3400 kgn3400 marked this pull request as ready for review January 21, 2025 21:27
@home-assistant home-assistant bot requested a review from frenck January 21, 2025 21:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you answer, however, we are not looking for collecting custom things in this repository. Instead, we want integrations to represent the brands they integrate with.

This means, the DR branding should be used.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 22, 2025 08:38
@kgn3400
Copy link
Contributor Author

kgn3400 commented Jan 22, 2025

Hi @frenck,

Changed the icons to use DR P4 radio station brand.

Best regards
Kurt G. Nielsen

@kgn3400 kgn3400 marked this pull request as ready for review January 22, 2025 13:36
@home-assistant home-assistant bot requested a review from frenck January 22, 2025 13:36
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kgn3400 👍

../Frenck

@frenck frenck merged commit 3709a7b into home-assistant:master Jan 22, 2025
5 checks passed
@kgn3400 kgn3400 deleted the trafikmeldinger branch January 22, 2025 20:00
@kgn3400 kgn3400 restored the trafikmeldinger branch January 22, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants