-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for Trafikmeldinger custom integration #6366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @kgn3400 👋
The information data provider used by this integration is DR:
I would have expected their branding to be used in this case?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi @frenck 🙂, www.dr.dk is the public service platform for TV, radio, news, sports, and traffic updates, etc here in Denmark. Their logo/branding is therefore generic to cover all the areas they represent: My user integration only forwards traffic update information from www.dr.dk. Therefore, I would like my user integration icon to clearly communicate to the end user that this is only related to traffic updates. Best regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you answer, however, we are not looking for collecting custom things in this repository. Instead, we want integrations to represent the brands they integrate with.
This means, the DR branding should be used.
../Frenck
Hi @frenck, Changed the icons to use DR P4 radio station brand. Best regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kgn3400 👍
../Frenck
Proposed change
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)[email protected]
)logo.png
)[email protected]
)