Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devtools custom integration #6322

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bendikrb
Copy link
Contributor

@bendikrb bendikrb commented Jan 4, 2025

Proposed change

Add icon+logo for my "developer tools" integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/bendikrb/ha-devtools

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is using a modified version of the Home Assistant and violating our general logo branding guidelines.

Please remove the use of the Home Assistant logo.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 4, 2025 10:15
@home-assistant
Copy link

home-assistant bot commented Jan 4, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think you should get rid of the house & color that resembles our logo. Please note, our logo is copyrighted.

../Frenck

@bendikrb bendikrb marked this pull request as ready for review January 4, 2025 13:02
@home-assistant home-assistant bot requested a review from frenck January 4, 2025 13:02
@bendikrb
Copy link
Contributor Author

bendikrb commented Jan 4, 2025

Thank you for your quick review, Frenck.

Yea I had a hunch that it might not fly with regards to the branding guidelines... I've uploaded an alternative version now. I hope this new design is sufficiently distinct from the HA logo to be acceptable?

@frenck
Copy link
Member

frenck commented Jan 4, 2025

My last response was about your latest iteration.

../Frenck

@frenck frenck marked this pull request as draft January 4, 2025 13:04
@frenck frenck removed their request for review January 4, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants