Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire an event when a navigation entity is selected while driving #4637

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

dshokouhi
Copy link
Member

@dshokouhi dshokouhi commented Sep 13, 2024

Summary

Fixes: #4315 by adding a new event android.navigation_started which only occurs for navigation entities in the driving interface.

which provides the following example event data:

event_type: android.navigation_started
data:
  entity_id: zone.test
  device_id: DEVICE_ID
origin: REMOTE
time_fired: "2024-09-13T23:10:24.304583+00:00"
context:
  id: ID
  parent_id: null
  user_id: USER_ID

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#1103

Any other notes

@jpelgrom
Copy link
Member

I'm still not sold on this because of the slippery slope of adding this to all clicks with >1 requester as it might be useful to someone, somehow - as discussed in the original issue. What made you change your mind?

@dshokouhi
Copy link
Member Author

Personally speaking I dont think we should add this to all other entities but i do see value in navigating to an entity which I dont think is a frequent action users will take.

@jpelgrom
Copy link
Member

This function will directly throw exceptions in case the call wasn't successful which should be caught :)

@jpelgrom jpelgrom merged commit f1f99c7 into home-assistant:master Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Auto - Allow Automations to be triggered when selecting somewhere to navigate
2 participants