Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable health connect to satisfy play console #4610

Merged

Conversation

dshokouhi
Copy link
Member

Summary

Our releases are stuck in a weird place given health connect approval is taking longer than anticipated and the required SDK bump deadline has passed.

For now lets temporarily comment out the code for permissions and health connect sensors while we satisfy the SDK requirements. Once completed and reviewed we should revert this change and try again for approval.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

more details: #4452 (comment)

@jpelgrom
Copy link
Member

jpelgrom commented Sep 5, 2024

Let's unblock this :)

@dshokouhi dshokouhi marked this pull request as ready for review September 5, 2024 22:20
@dshokouhi dshokouhi merged commit 445939f into home-assistant:master Sep 6, 2024
4 checks passed
dshokouhi added a commit that referenced this pull request Sep 24, 2024
@mapsindustrial
Copy link

Guys, I am very very interested in being able to try the great work you have done, is there any possibility of trying the apk?

@dshokouhi
Copy link
Member Author

Guys, I am very very interested in being able to try the great work you have done, is there any possibility of trying the apk?

just give some patience, we are waiting on the current production release to be approved by Google so we can move forward with #4663 so we can hopefully apply for the approval so the features can work.

@mapsindustrial
Copy link

Do you know an approximate date? Will they release the apk in the Google Pay Store?

@dshokouhi
Copy link
Member Author

no date, and yes it will be in the play store once approved

@mapsindustrial
Copy link

Great, that's great news. I'm crossing my fingers to have a date soon.

Thank you so much!

dshokouhi added a commit that referenced this pull request Oct 6, 2024
…4663)

Revert "Temporarily disable health connect to satisfy play console (#4610)"

This reverts commit 445939f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants