Fix crash on app start/API use on SDK <26 #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Manually specify databind version to fix FasterXML/jackson-databind#3412, as the Kotlin module still depends on the unfixed version and hasn't had a new release yet
dshokouhi
approved these changes
May 1, 2022
|
Well it's been almost 1.5 months since the dependency upgrade that causes the issue was merged so I wouldn't say the issue was spotted "quickly"... |
JBassett
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2465, fixes #2477
FasterXML/jackson-databind#3412 results in a crash when the app tries to use the Jackson databind library on devices with API level < 26 (= basically any API call, so from the moment the app starts and tries to contact the server). Manually specify the
jackson-databinddependency with the latest version that includes a fix for now, Gradle will choose the highest version which solves the problem.Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes