Add/improve support for Glances v4 container & network format and improve v4 unit tests #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Glances v4 container format change, while retaining compatibility with earlier versions of HA.
=> Fixes issue #41
The PR also addresses another issue in Glances v4, where Glances sends an incomplete network sensor when the module is disabled. The code was reworked to be more robust when Glances sends incomplete data.
Finally the PR adds dedicated unit tests for v4 data (parametrized test for get_ha_sensor_data).
Related HA issue : home-assistant/core#118632
Related Glances issue : nicolargo/glances#2815
As there are now 3 different formats of API for the containers, I have opted for a test on the Glances version rather than looking for the various possibilities.
To sum up the formats :