Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bookmark widget #964

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from
Draft

feat: add bookmark widget #964

wants to merge 14 commits into from

Conversation

manuel-rw
Copy link
Member

@manuel-rw manuel-rw commented Aug 10, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #955

Screenshots

image
image
image

@manuel-rw manuel-rw self-assigned this Aug 10, 2024
Copy link

deepsource-io bot commented Aug 10, 2024

Here's the code health analysis summary for commits da2c8fa..4cd5268. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Aug 10, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.99% 13723 / 35195
🔵 Statements 38.99% 13723 / 35195
🔵 Functions 35.07% 362 / 1032
🔵 Branches 70.6% 1225 / 1735
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/api/src/router/app.ts 78.04% 100% 100% 78.04% 16-25, 30-34, 51-53
packages/definitions/src/widget.ts 100% 100% 100% 100%
packages/old-import/src/import-apps.ts 7.76% 100% 0% 7.76% 18-26, 28-34, 36, 39-41, 43, 45-56, 58, 60-62, 64, 67-73, 82-85, 87-92, 102-112, 114-126, 128-135, 143-147, 155-157
packages/old-import/src/import-items.ts 10.95% 100% 0% 10.95% 16-23, 25, 27-29, 31, 33, 35-38, 41, 43, 45-48, 50-59, 61-62, 64, 66-68, 71, 73, 75-78, 80-88, 91-97, 99-101
packages/old-import/src/index.ts 17.64% 100% 0% 17.64% 15-18, 20-35, 37-40, 42-56, 58-60
packages/old-import/src/widgets/options.ts 81.89% 100% 0% 81.89% 125-132, 134-146
packages/old-import/src/widgets/definitions/bookmark.ts 0% 0% 0% 0%
packages/old-import/src/widgets/definitions/index.ts 95.65% 100% 0% 95.65% 78
packages/translation/src/lang/en.ts 100% 100% 100% 100%
packages/widgets/src/index.tsx 75.43% 100% 0% 75.43% 64-65, 67-73, 75-76, 78-80
packages/widgets/src/options.ts 87.27% 69.69% 91.66% 87.27% 106-109, 193-202
packages/widgets/src/_inputs/common.tsx 42.85% 100% 0% 42.85% 26-29
packages/widgets/src/_inputs/index.ts 92.3% 100% 0% 92.3% 27-28
packages/widgets/src/_inputs/widget-sortable-item-list-input.tsx 5.64% 100% 0% 5.64% 28-39, 41-51, 53-57, 59-63, 65-68, 70-72, 74-80, 82-85, 87-90, 92-94, 96-99, 101-108, 110-126, 128-130, 132-140, 142-146, 148-154, 156, 167-175, 177-185, 187-188, 190, 192-215, 217, 219-226, 228
packages/widgets/src/bookmarks/app-select-modal.tsx 26.82% 100% 0% 26.82% 25-33, 35-37, 39-40, 42-61, 63-73, 87-93, 103-105, 107-109, 111-112
packages/widgets/src/bookmarks/component.tsx 0% 0% 0% 0% 1, 3, 6, 10-15, 17-23, 25, 33, 35, 37-44, 46-53, 55-79, 81
packages/widgets/src/bookmarks/index.tsx 40% 100% 0% 40% 19-22, 24-30, 32-35, 37, 39-40, 42-45, 47, 50, 52-57
packages/widgets/src/modals/widget-edit-modal.tsx 16.8% 100% 0% 16.8% 38-39, 42-53, 55-69, 71, 73-81, 83-90, 92-93, 95, 97, 99-107, 109-116, 118-132, 135-148, 153-154
Generated in workflow #3003

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmark
2 participants