Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turned several LIMAT immediate methods into methods #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

turned several LIMAT immediate methods into methods #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MatricesForHomalg/PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ PackageName := "MatricesForHomalg",
Subtitle := "Matrices for the homalg project",

Version := Maximum( [
"2020.09.05", ## Mohamed's version
"2020.10.03", ## Mohamed's version
## this line prevents merge conflicts
"2020.10.02", ## Fabian's version
## this line prevents merge conflicts
Expand Down
44 changes: 22 additions & 22 deletions MatricesForHomalg/gap/LIMAT.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,8 @@ InstallImmediateMethod( ZeroRows,
end );

##
InstallImmediateMethod( ZeroRows,
IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerRow and HasNrRows, 0,
InstallMethod( ZeroRows,
[ IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerRow and HasNrRows ], 0,

function( M )
local pos;
Expand All @@ -510,8 +510,8 @@ InstallImmediateMethod( ZeroRows,
end );

##
InstallImmediateMethod( ZeroRows,
IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerColumn and IsSubidentityMatrix and HasNrRows, 0,
InstallMethod( ZeroRows,
[ IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerColumn and IsSubidentityMatrix and HasNrRows ], 0,

function( M )
local pos;
Expand All @@ -523,8 +523,8 @@ InstallImmediateMethod( ZeroRows,
end );

##
InstallImmediateMethod( ZeroRows,
IsHomalgMatrix and HasEvalCertainRows, 0,
InstallMethod( ZeroRows,
[ IsHomalgMatrix and HasEvalCertainRows ], 0,

function( M )
local e;
Expand Down Expand Up @@ -577,8 +577,8 @@ InstallImmediateMethod( ZeroColumns,
end );

##
InstallImmediateMethod( ZeroColumns,
IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerColumn and HasNrColumns, 0,
InstallMethod( ZeroColumns,
[ IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerColumn and HasNrColumns ], 0,

function( M )
local pos;
Expand All @@ -590,8 +590,8 @@ InstallImmediateMethod( ZeroColumns,
end );

##
InstallImmediateMethod( ZeroColumns,
IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerRow and IsSubidentityMatrix and HasNrColumns, 0,
InstallMethod( ZeroColumns,
[ IsHomalgMatrix and HasPositionOfFirstNonZeroEntryPerRow and IsSubidentityMatrix and HasNrColumns ], 0,

function( M )
local pos;
Expand All @@ -603,8 +603,8 @@ InstallImmediateMethod( ZeroColumns,
end );

##
InstallImmediateMethod( ZeroColumns,
IsHomalgMatrix and HasEvalCertainColumns, 0,
InstallMethod( ZeroColumns,
[ IsHomalgMatrix and HasEvalCertainColumns ], 0,

function( M )
local e;
Expand All @@ -623,8 +623,8 @@ InstallImmediateMethod( ZeroColumns,
end );

##
InstallImmediateMethod( NonZeroRows,
IsHomalgMatrix and HasZeroRows and HasNrRows, 0,
InstallMethod( NonZeroRows,
[ IsHomalgMatrix and HasZeroRows and HasNrRows ], 0,

function( M )

Expand Down Expand Up @@ -653,8 +653,8 @@ InstallImmediateMethod( NonZeroRows,
end );

##
InstallImmediateMethod( NonZeroColumns,
IsHomalgMatrix and HasZeroColumns and HasNrColumns, 0,
InstallMethod( NonZeroColumns,
[ IsHomalgMatrix and HasZeroColumns and HasNrColumns ], 0,

function( M )

Expand Down Expand Up @@ -696,9 +696,9 @@ InstallImmediateMethod( PositionOfFirstNonZeroEntryPerRow,

end );

##
InstallImmediateMethod( PositionOfFirstNonZeroEntryPerRow,
IsHomalgMatrix and IsZero and HasNrRows, 0,
## the result might be too big, so only compute when necessary
InstallMethod( PositionOfFirstNonZeroEntryPerRow,
[ IsHomalgMatrix and IsZero and HasNrRows ], 0,

function( M )

Expand All @@ -720,9 +720,9 @@ InstallImmediateMethod( PositionOfFirstNonZeroEntryPerColumn,

end );

##
InstallImmediateMethod( PositionOfFirstNonZeroEntryPerColumn,
IsHomalgMatrix and IsZero and HasNrColumns, 0,
## the result might be too big, so only compute when necessary
InstallMethod( PositionOfFirstNonZeroEntryPerColumn,
[ IsHomalgMatrix and IsZero and HasNrColumns ], 0,

function( M )

Expand Down