Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutability and indices for Gauss sparse matrices #184

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mutability and indices for Gauss sparse matrices #184

wants to merge 2 commits into from

Conversation

markuspf
Copy link

@markuspf markuspf commented Dec 9, 2017

This PR does two things (which I could split into 2 PRs if requested):

  • Add the IsMutable filter to sparse matrices. They were always mutable, because SetEntry worked on them. MakeImmutable now works, but we're missing MutableCopyMat.
  • Add methods that allow sparsemat[i,j] and sparsemat[i,j] := 4 access for sparse matrices.

@markuspf
Fix mutability filters for sparse matrices and add methods for mat[i,j]
5571d63 
For the assignment to work, sparse matrices have to be mutable
(which they always were: one could call SetEntry on them
without problems).

There is scope to make immutable variants of these matrices in the
future.
@markuspf
Whitespace cleanup
ac482ca
@mohamed-barakat
Copy link
Member

Your first commit breaks the package PrimaryDecomposition. I need to investigate.

@mohamed-barakat
Copy link
Member

@markuspf: Let us please talk about this PR this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markuspf @mohamed-barakat