Colift #70
Open
Colift #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamed-barakat
force-pushed
the
Colift
branch
2 times, most recently
from
413609d
to
2866410
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 2097 2121 +24
=========================================
+ Hits 2097 2121 +24 ☔ View full report in Codecov by Sentry. |
zickgraf
requested changes
Dec 3, 2021
gap/FinSetsForCAP.gi
Outdated
| function ( category_of_finite_sets, alpha, beta ) | ||
|
|
||
| return ForAll( AsList( ImageObject( alpha ) ), | ||
| i -> Length( DuplicateFreeList( List( Preimage( alpha, FinSetNC( category_of_finite_sets, [ i ] ) ), beta ) ) ) = 1 ); |
There was a problem hiding this comment.
We must not use DuplicateFreeList because that would compare elements via =, but we compare elements via IsEqualForElementsOfFinSets.
mohamed-barakat
force-pushed
the
Colift
branch
from
2866410
to
7f818cc
Compare
mohamed-barakat
force-pushed
the
Colift
branch
3 times, most recently
from
c20c5e7
to
35406ff
Compare
mohamed-barakat
force-pushed
the
Colift
branch
2 times, most recently
from
c584965
to
d9759cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.