Rename install.sh to prerequisites.sh #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I didn't realize it, but this is missing code in And perhaps |
The BuildPackages.sh script automatically executes `prerequisites.sh`, as do the GitHub Actions used for Ci tests. The former means that that CddInterface will end up being available for more users than without this. The latter means that the GitHub Actions don't need to install libcdd-dev anymore.
fingolfin
force-pushed
the
mh/prerequisites.sh
branch
from
c1f72c5
to
d81cd9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, GAP's BuildPackages.sh script will automatically execute it, meaning that cddlib will end up being available for more users than without this.
The GH actions CI scripts also use this, so no need for libcdd-dev anymore.
Contains PR #33. Closes PR #33