Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several category constructors now use FinQuiver instead of RightQuiver #584

Merged

Conversation

mohamed-barakat
Copy link
Member

  • SimplicialCategoryTruncatedInDegree
  • CategoryOfBouquetsEnrichedOver
  • CategoryOfQuiversEnrichedOver

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 94.82353% with 44 lines in your changes missing coverage. Please review.

Project coverage is 75.90%. Comparing base (77d66e0) to head (bf45b16).

Files with missing lines Patch % Lines
FunctorCategories/gap/PreSheaves.gi 56.60% 23 Missing ⚠️
FpCategories/gap/PathCategories.gi 89.55% 7 Missing ⚠️
FpCategories/gap/QuotientsOfPathCategories.gi 96.70% 3 Missing ⚠️
FpCategories/gap/SimplicialCategory.gi 89.28% 3 Missing ⚠️
FpCategories/gap/Tools.gd 88.23% 2 Missing ⚠️
FpCategories/gap/QuotientsOfPathCategories.gd 87.50% 1 Missing ⚠️
FpCategories/gap/Tools.gi 99.79% 1 Missing ⚠️
...FromNerveDataHomStructureOnMorphismsPrecompiled.gi 0.00% 1 Missing ⚠️
...led_categories/CategoryFromNerveDataPrecompiled.gi 0.00% 1 Missing ⚠️
FpCategories/init.g 80.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   76.34%   75.90%   -0.45%     
==========================================
  Files         400      400              
  Lines       59564    59820     +256     
==========================================
- Hits        45473    45405      -68     
- Misses      14091    14415     +324     
Flag Coverage Δ
Algebroids 73.33% <100.00%> (-2.70%) ⬇️
CatReps 83.54% <ø> (ø)
CategoriesWithAmbientObjects 89.28% <ø> (ø)
ExteriorPowersCategories 43.70% <ø> (ø)
FiniteCocompletions 92.44% <100.00%> (ø)
FpCategories 91.87% <97.25%> (+3.74%) ⬆️
FunctorCategories 63.73% <63.07%> (-1.59%) ⬇️
GradedCategories 86.57% <ø> (ø)
InternalModules 81.68% <ø> (ø)
IntrinsicCategories 82.47% <ø> (ø)
IntrinsicGradedModules 50.83% <ø> (ø)
IntrinsicModules 82.15% <ø> (ø)
LazyCategories 68.39% <ø> (ø)
Locales 86.44% <ø> (ø)
PreSheaves 89.90% <ø> (ø)
QuotientCategories 92.08% <ø> (ø)
SubcategoriesForCAP 81.22% <ø> (ø)
ToolsForCategoricalTowers 84.46% <ø> (ø)
Toposes 90.91% <ø> (ø)
ZariskiFrames 74.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* SimplicialCategoryTruncatedInDegree
* CategoryOfBouquetsEnrichedOver
* CategoryOfQuiversEnrichedOver
@mohamed-barakat mohamed-barakat merged commit 26623a8 into homalg-project:master Sep 24, 2024
3 of 4 checks passed
@mohamed-barakat mohamed-barakat deleted the CategoryFromNerveData branch September 24, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant