Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace b in ListImpliedFilters( a ) -> IsSpecializationOfFilter( b, a ) #582

Merged
merged 1 commit into from
Sep 18, 2024
Merged

replace b in ListImpliedFilters( a ) -> IsSpecializationOfFilter( b, a ) #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LazyCategories/PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SetPackageInfo( rec(

PackageName := "LazyCategories",
Subtitle := "Construct an equivalent lazy category out of a CAP category",
Version := "2024.09-03",
Version := "2024.09-04",
Date := ~.Version{[ 1 .. 10 ]},
Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
License := "GPL-2.0-or-later",
Expand Down
2 changes: 1 addition & 1 deletion LazyCategories/gap/LazyCategory.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ InstallMethod( LazyCategory,
properties := ListKnownCategoricalProperties( C );

ignore := [ "IsSkeletalCategory" ];
Append( ignore, Filtered( properties, p -> "IsSkeletalCategory" in ListImpliedFilters( FilterByName( p ) ) ) );
Append( ignore, Filtered( properties, p -> IsSpecializationOfFilter( IsSkeletalCategory, FilterByName( p ) ) ) );
Append( ignore, Filtered( properties, p -> IsInt( PositionSublist( p, "Strict" ) ) ) );
Append( ignore, Filtered( properties, p -> ForAny( ListImpliedFilters( FilterByName( p ) ), i -> IsInt( PositionSublist( i, "Strict" ) ) ) ) );

Expand Down
2 changes: 1 addition & 1 deletion ToolsForCategoricalTowers/PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SetPackageInfo( rec(

PackageName := "ToolsForCategoricalTowers",
Subtitle := "Tools for CategoricalTowers",
Version := "2024.09-04",
Version := "2024.09-05",

Date := ~.Version{[ 1 .. 10 ]},
Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
Expand Down
4 changes: 2 additions & 2 deletions ToolsForCategoricalTowers/gap/Tools.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ InstallMethod( DummyCategoryInDoctrines,

bool := IsSubset( ListMethodsOfDoctrine( a ), ListMethodsOfDoctrine( b ) );

if minimal = true and IsBoundGlobal( a ) then
return ( b in ListImpliedFilters( ValueGlobal( a ) ) ) or bool;
if minimal = true and IsBoundGlobal( a ) and IsBoundGlobal( b ) then
return IsSpecializationOfFilter( ValueGlobal( b ), ValueGlobal( a ) ) or bool;
else
return bool;
fi;
Expand Down
Loading