Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added error message to constructors MeetSemilatticeOfSingle/MultipleDifferences #265

Merged
merged 1 commit into from
Jun 28, 2023
Merged

added error message to constructors MeetSemilatticeOfSingle/MultipleDifferences #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Locales/PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SetPackageInfo( rec(

PackageName := "Locales",
Subtitle := "Locales, frames, coframes, meet semi-lattices of locally closed subsets, and Boolean algebras of constructible sets",
Version := "2023.06-13",
Version := "2023.06-14",
Date := ~.Version{[ 1 .. 10 ]},
Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
License := "GPL-2.0-or-later",
Expand Down
5 changes: 5 additions & 0 deletions Locales/gap/MultipleDifferences.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
function( P )
local name, D;

if not ( HasIsDistributiveBicartesianProset( P ) and IsDistributiveBicartesianProset( P ) ) then
Error( "the input category `P` must be a distributive (bicartesian) proset (e.g. a distributive lattice) ",
"for the meet-semilattice of multiple differences to be well-defined\n" );

Check warning on line 36 in Locales/gap/MultipleDifferences.gi

View check run for this annotation

Codecov / codecov/patch

Locales/gap/MultipleDifferences.gi#L35-L36 

Added lines #L35 - L36 were not covered by tests
fi;

name := "The meet-semilattice of multiple differences of ";

name := Concatenation( name, Name( P ) );
Expand Down
6 changes: 6 additions & 0 deletions Locales/gap/SingleDifferences.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@
function( P )
local name, D, L;

if not ( HasIsDistributiveBicartesianProset( P ) and IsDistributiveBicartesianProset( P ) ) then
Error( "the input category `P` must be a distributive (bicartesian) proset (e.g. a distributive lattice) ",
"for the meet-semilattice of single differences to be well-defined\n" );

Check warning on line 41 in Locales/gap/SingleDifferences.gi

View check run for this annotation

Codecov / codecov/patch

Locales/gap/SingleDifferences.gi#L40-L41 

Added lines #L40 - L41 were not covered by tests
fi;

name := "The meet-semilattice of single differences of ";

name := Concatenation( name, Name( P ) );
Expand Down Expand Up @@ -84,6 +89,7 @@

end );

## the following is independent of the representatives of the single differences when the given bicartesian proset is (co)distributive
## (A - A') ≤_D (B - B') ⟺ ( A ≤_C ( A' ∨ B ) ) and ( ( A ∧ B' ) ≤_C A' )
AddIsHomSetInhabited( D,
function( D, A, B )
Expand Down