Merge pull request #588 from mohamed-barakat/devel

fixed loading of Julia.gi
homalg-project · Sep 29, 2024 · ea57cf8 · ea57cf8
2 parents 91f4ed7 + 76fba5f
commit ea57cf8
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/FpCategories/PackageInfo.g b/FpCategories/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "FpCategories",
 Subtitle := "Finitely presented categories by generating quivers and relations",
-Version := "2024.09-06",
+Version := "2024.09-07",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/FpCategories/gap/Quivers.gd b/FpCategories/gap/Quivers.gd
@@ -45,7 +45,7 @@ DeclareCategory( "IsFinQuiverMorphism",
 #!    This list might contain an optional fifth entry for the list of LaTeX-strings for the morphisms.
 #! @Arguments q_datum
 #! @Returns a &CAP; quiver
-DeclareGlobalFunction( "FinQuiver" );
+DeclareOperation( "FinQuiver", [ IsList ] );
 #! @InsertChunk FinQuiver
 
 if false then

diff --git a/FpCategories/gap/Quivers.gi b/FpCategories/gap/Quivers.gi
@@ -152,7 +152,8 @@ InstallGlobalFunction( RandomFinQuiver,
 end );
 
 ##
-InstallGlobalFunction( FinQuiver,
+InstallMethod( FinQuiver,
+        [ IsList ],
 
   function ( q_datum )
     local colors, name, q;

diff --git a/FpCategories/init.g b/FpCategories/init.g
@@ -12,7 +12,3 @@ ReadPackage( "FpCategories", "gap/CategoryFromNerveData.gd");
 ReadPackage( "FpCategories", "gap/Tools.gd");
 ReadPackage( "FpCategories", "gap/ToolsMethodRecordDeclarations.autogen.gd");
 ReadPackage( "FpCategories", "gap/SimplicialCategory.gd");
-
-if IsPackageMarkedForLoading( "JuliaInterface", ">= 0.2" ) then
-    ReadPackage( "FpCategories", "gap/Julia.gi" );
-fi;
diff --git a/FpCategories/read.g b/FpCategories/read.g
@@ -17,3 +17,7 @@ ReadPackage( "FpCategories", "gap/ToolsMethodRecord.gi");
 ReadPackage( "FpCategories", "gap/ToolsMethodRecordInstallations.autogen.gi");
 ReadPackage( "FpCategories", "gap/ToolsDerivedMethods.gi");
 ReadPackage( "FpCategories", "gap/SimplicialCategory.gi");
+
+if IsPackageMarkedForLoading( "JuliaInterface", ">= 0.2" ) then
+    ReadPackage( "FpCategories", "gap/Julia.gi" );
+fi;