Merge pull request #582 from mohamed-barakat/IsSpecializationOfFilter

replace b in ListImpliedFilters( a ) -> IsSpecializationOfFilter( b, a )
homalg-project · Sep 18, 2024 · a3da0f6 · a3da0f6
2 parents 3cef36c + ed7c5e3
commit a3da0f6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/LazyCategories/PackageInfo.g b/LazyCategories/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "LazyCategories",
 Subtitle := "Construct an equivalent lazy category out of a CAP category",
-Version := "2024.09-03",
+Version := "2024.09-04",
 Date := ~.Version{[ 1 .. 10 ]},
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",

diff --git a/LazyCategories/gap/LazyCategory.gi b/LazyCategories/gap/LazyCategory.gi
@@ -500,7 +500,7 @@ InstallMethod( LazyCategory,
     properties := ListKnownCategoricalProperties( C );
 
     ignore := [ "IsSkeletalCategory" ];
-    Append( ignore, Filtered( properties, p -> "IsSkeletalCategory" in ListImpliedFilters( FilterByName( p ) ) ) );
+    Append( ignore, Filtered( properties, p -> IsSpecializationOfFilter( IsSkeletalCategory, FilterByName( p ) ) ) );
     Append( ignore, Filtered( properties, p -> IsInt( PositionSublist( p, "Strict" ) ) ) );
     Append( ignore, Filtered( properties, p -> ForAny( ListImpliedFilters( FilterByName( p ) ), i -> IsInt( PositionSublist( i, "Strict" ) ) ) ) );
 

diff --git a/ToolsForCategoricalTowers/PackageInfo.g b/ToolsForCategoricalTowers/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "ToolsForCategoricalTowers",
 Subtitle := "Tools for CategoricalTowers",
-Version := "2024.09-04",
+Version := "2024.09-05",
 
 Date := ~.Version{[ 1 .. 10 ]},
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),

diff --git a/ToolsForCategoricalTowers/gap/Tools.gi b/ToolsForCategoricalTowers/gap/Tools.gi
@@ -44,8 +44,8 @@ InstallMethod( DummyCategoryInDoctrines,
 
         bool := IsSubset( ListMethodsOfDoctrine( a ), ListMethodsOfDoctrine( b ) );
 
-        if minimal = true and IsBoundGlobal( a ) then
-            return ( b in ListImpliedFilters( ValueGlobal( a ) ) ) or bool;
+        if minimal = true and IsBoundGlobal( a ) and IsBoundGlobal( b ) then
+            return IsSpecializationOfFilter( ValueGlobal( b ), ValueGlobal( a ) ) or bool;
         else
             return bool;
         fi;