Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: use find_spec for spatialpandas.dask import #163

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 6, 2024

Previous if some import failed in import spatialpandas.dask there was no way to see it. It was leading to weird behavior.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.47%. Comparing base (7aabfff) to head (c50d8d6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   77.50%   77.47%   -0.03%     
==========================================
  Files          50       50              
  Lines        4845     4844       -1     
==========================================
- Hits         3755     3753       -2     
- Misses       1090     1091       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit 3a1b6eb into main Nov 12, 2024
12 checks passed
@hoxbro hoxbro deleted the find_spec_import branch November 12, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants