Ensure edit_constant resets class and instance level parameters #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1014
Fixes #931
Regression introduced in Param 2.0.0 in #826 that introduced installing an instance parameter (copied from the class) on
__set__
(6ce1ef3). The context manageredit_constant
was first getting a handle on all the existing parameters (mix of class and instance level parameters), yielding, and then resettingconstant
on the parameters already handled, missing that the parameterized object could have been equipped with instance-level parameters that were created withconstant=False
.This is fixed in this MR, which also only touches the constant parameters.