Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in is_viewable_param #7454

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix bug in is_viewable_param #7454

merged 2 commits into from
Nov 1, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Nov 1, 2024

I was trying to use param.ClassSelector(class_=(list,tuple) with the GraphicWalker react component and I got

TypeError: issubclass() arg 1 must be a class

panel/viewable.py:1215: TypeError

This PR should add a test for this and fix the issue.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (b43a52a) to head (c407425).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7454      +/-   ##
==========================================
+ Coverage   82.27%   82.29%   +0.02%     
==========================================
  Files         338      338              
  Lines       50772    50819      +47     
==========================================
+ Hits        41774    41824      +50     
+ Misses       8998     8995       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit c06f779 into main Nov 1, 2024
18 checks passed
@philippjfr philippjfr deleted the fix/arg1-must-be-class branch November 1, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants