Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move session prefixes from handlers to Application #7318

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

philippjfr
Copy link
Member

Moving the handling of relative paths and the base urls from the tornado handlers to the Application ensures that all server implementations inherit this handling rather than merely being supported by the Tornado server implementation.

Fixes bokeh/bokeh-fastapi#24

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (81ccf03) to head (9f2cbf2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/server.py 88.88% 3 Missing ⚠️
panel/io/state.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7318   +/-   ##
=======================================
  Coverage   82.20%   82.21%           
=======================================
  Files         337      337           
  Lines       50442    50462   +20     
=======================================
+ Hits        41464    41485   +21     
+ Misses       8978     8977    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/io/application.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit 9f51bb4 into main Sep 24, 2024
15 checks passed
@philippjfr philippjfr deleted the session_prefix_handling branch September 24, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested path not working.
1 participant