Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to improve Tabulator robustness #7275

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 14, 2024

Two fixes to improve Tabulator robustness:

  1. Guard this.model.children look-ups since, when empty it sometimes appears to be an object rather than a Map.
  2. Track scrolling state more robustly and do not run resize handler while scrolling (this was triggering tons of re-renders)

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (d57d393) to head (3209f77).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7275      +/-   ##
==========================================
- Coverage   82.19%   82.19%   -0.01%     
==========================================
  Files         337      337              
  Lines       50363    50363              
==========================================
- Hits        41398    41394       -4     
- Misses       8965     8969       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 84e5040 into main Sep 16, 2024
16 checks passed
@philippjfr philippjfr deleted the tabulator_robustness branch September 16, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants