Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up ChatMessage layout #7255

Closed
wants to merge 1 commit into from
Closed

Tighten up ChatMessage layout #7255

wants to merge 1 commit into from

Conversation

philippjfr
Copy link
Member

Was just looking at the new ChatMessage and while it's an improvement the alignment of the icons and the spacing bothered me a little bit. So this PR tightens things up a bit:

Before

Screenshot 2024-09-11 at 14 50 38

After

Screenshot 2024-09-11 at 14 45 28

@philippjfr
Copy link
Member Author

Seems a tiny bit unbalanced still, the divider should maybe have an extra pixel on the right.

@philippjfr philippjfr added this to the v1.5.0 milestone Sep 11, 2024
@ahuang11
Copy link
Contributor

Seems very tight on my end
image

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (2b0b90e) to head (ad4d058).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7255      +/-   ##
==========================================
+ Coverage   82.23%   82.24%   +0.01%     
==========================================
  Files         337      337              
  Lines       50258    50259       +1     
==========================================
+ Hits        41332    41338       +6     
+ Misses       8926     8921       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member Author

Indeed, that looks to cramped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants