Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start duckdb implementation of dremio #683

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Start duckdb implementation of dremio #683

wants to merge 8 commits into from

Conversation

ahuang11
Copy link
Contributor

Started migrating stuff over to DuckDB source and will start testing.

Based off https://www.dremio.com/blog/using-duckdb-with-your-dremio-data-lakehouse/

With a well-curated semantic layer, Dremio makes access and discovery of data much easier for analysts to pull the data they need and have permission to access using Apache Arrow Flight. They can then proceed locally for ad hoc queries on the subset of the data they pulled from Dremio

So essentially, we still have to read the entire dataset and migrate it into a duckdb source. Previously with intake-dremio, I think we were doing dremio -> intake -> duckdb. now it's dremio -> duckdb

While doing that, would like your feedback on implementation or anything.

I think there are things we can tinker with for optimizing the reads like read_chunk and partitioning, etc

def dataset(source, schema=None, format=None, filesystem=None,
            partitioning=None, partition_base_dir=None,
            exclude_invalid_files=None, ignore_prefixes=None):

@ahuang11 ahuang11 requested a review from philippjfr August 21, 2024 20:47
from pyarrow import flight


class DremioClientAuthMiddleware(flight.ClientMiddleware):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure where I should put this; I pulled it from intake-dremio.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 16.05839% with 115 lines in your changes missing coverage. Please review.

Project coverage is 56.22%. Comparing base (2622c0b) to head (7d93365).
Report is 8 commits behind head on main.

Files Patch % Lines
lumen/sources/duckdb.py 20.95% 83 Missing ⚠️
lumen/sources/dremio_utils.py 0.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   57.03%   56.22%   -0.81%     
==========================================
  Files          98       99       +1     
  Lines       11598    11804     +206     
==========================================
+ Hits         6615     6637      +22     
- Misses       4983     5167     +184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lumen/sources/duckdb.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant