Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow roundtrip of Layout to_spec and from_spec #495

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fixes #486

@codecov-commenter
Copy link

Codecov Report

Merging #495 (0a09c41) into main (592e75b) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   69.36%   69.34%   -0.03%     
==========================================
  Files          79       79              
  Lines        9128     9131       +3     
==========================================
  Hits         6332     6332              
- Misses       2796     2799       +3     
Files Coverage Δ
lumen/layout.py 79.10% <16.66%> (-0.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 6d59bcf into main Oct 31, 2023
10 checks passed
@philippjfr philippjfr deleted the roundtrip_layout branch October 31, 2023 22:28
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round trip Layout to_spec and from_spec
2 participants